[MXNET-1232] fix demo and add Eclipse support #13979
Conversation
| </os> | ||
| </activation> | ||
| <properties> | ||
| <mxnet.profile>linux-x86_64-cpu</mxnet.profile> |
There was a problem hiding this comment.
This will always pick the cpu artifact. The existing code allows one to pick up the gpu artifacts as well.
There was a problem hiding this comment.
In order to simplify the process, I decided to get rid of the makefile entirely. To address your concern, I add a noteline in the README to inform then using GPU to run
There was a problem hiding this comment.
Yeah. removing makefile was a good riddance :)
I'm fine with adding it to the README.
|
@aaronmarkham Could you please review this? |
There was a problem hiding this comment.
I removed many references to "simply" since quite often there are issues and nothing is entirely simple. The implication to someone that fails on a "simple" command is that they have substandard intelligence and cannot complete even the most simple task. 🤷♀️ It's just nicer if we avoid assigning complexity levels to various steps.
There are also a lot of "required" statements in here and I think that might not be true. Maven is an option and possibly the easiest, but certainly not the only way to do it.
| ### Eclipse IDE Support | ||
| You can easily convert you existing maven project to a project that can run in Eclipse by: | ||
| ``` | ||
| mvn eclipse:eclipse |
There was a problem hiding this comment.
From what directory? Is this known or should you mention it?
There was a problem hiding this comment.
This is known, mvn command could only execute in a folder that has a pom file.
There was a problem hiding this comment.
I also add one line to explain that
| ## Run in Eclipse | ||
| You can convert the maven project to the eclipse one by running | ||
| ``` | ||
| mvn eclipse:eclipse |
There was a problem hiding this comment.
This is a repeat of before... why is this here?
Also this is a conversion instruction not a "run" instruction as the title suggests. Maybe you can include some screenshots of how you open the project in eclipse and build it, etc...
There was a problem hiding this comment.
This is specifically for users trying to use Eclipse in their demo project
The latter step will just be click Eclipse and click import...
Co-Authored-By: lanking520 <[email protected]>
|
@aaronmarkham please give a 2nd phase review |
sandeep-krishnamurthy
added
Scala
Java
* fix demo and add Eclipse support * fix on docs * fix typo * Update docs/install/java_setup.md Co-Authored-By: lanking520 <[email protected]> * add fixes in docs
* fix demo and add Eclipse support * fix on docs * fix typo * Update docs/install/java_setup.md Co-Authored-By: lanking520 <[email protected]> * add fixes in docs
* fix demo and add Eclipse support * fix on docs * fix typo * Update docs/install/java_setup.md Co-Authored-By: lanking520 <[email protected]> * add fixes in docs
Description
Get rid of makefile and add Eclipse support for Java
@andrewfayres @piyushghai @zachgk @aaronmarkham
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.